This series makes the ref_count field of device and bus objects actually
match the number of references that the objects have. Once this is
done, the question "how do I delete an object?" has a simple answer:
use object_unparent if the object is reachable from the QOM tree, else use
object_unref. qdev_free and qbus_free become equivalent to simply
object_unparent. object_delete instead is replaced by object_unref.
Patches 1-4 fix some warts in the last minute patches that went in 1.3.
Patches 5-11 are the bulk of the series. Patches 12-13 touches the CPU
classes instead.
Paolo
v1->v2:
There is a new patch (#4) that documents how link properties are
reference counted, and the transfer of ownership when the property
is created/deleted. I renamed qbus_remove_children to bus_unparent,
and rebased for the conversion of ->state to ->realized. PPC was also
using object_delete for its CPU, too. Otherwise, there are no changes.
v2->v3:
Patches 1 and 2 reorganized to keep qbus_realize static. sysbus
still allocated with g_malloc.
v3->v4:
Fixed the PCI patch according to Andreas's suggestion, and documented
the reference count of new objects.
Paolo Bonzini (13):
qdev: remove duplication between qbus_create and qbus_create_inplace
qdev: change first argument of qbus_create_inplace to void *
pci: use qbus_create in pci_bus_new
qom: preserve object while unparenting it
qom: document reference counting of link properties
qdev: add reference count to a device for the BusChild
qdev: move deletion of children from finalize to unparent
qdev: move unrealization of devices from finalize to unparent
qdev: add reference for the bus while it is referred to by the
DeviceState
qdev: inline object_delete into qbus_free/qdev_free
qdev: drop extra references at creation time
cpu: do not use object_delete
qom: remove object_delete
hw/pci/pci.c | 21 ++++++---
hw/qdev-core.h | 2 +-
hw/qdev-monitor.c | 5 ++-
hw/qdev.c | 107 +++++++++++++++++++++++++-------------------
include/qom/object.h | 32 +++++++------
linux-user/syscall.c | 2 +-
qom/object.c | 9 +---
target-i386/helper.c | 4 +-
target-ppc/translate_init.c | 2 +-
target-sparc/cpu.c | 2 +-
vl.c | 1 +
11 files changed, 105 insertions(+), 82 deletions(-)
--
1.8.1
