On Sun, Feb 10, 2013 at 11:12:11PM +0100, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau <hpous...@reactos.org> > --- > hw/ide/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 3743dc3..f0ab1a8 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) > break; > case WIN_PACKETCMD: > /* overlapping commands not supported */ > - if (s->feature & 0x02) > + if (s->feature & 0x02) { > + qemu_log_mask(LOG_UNIMP, "ide: overlapping command not > supported");
qemu_log_*() isn't used much in hw/. I think we need to side-track this patch email to figure out what to use: fprintf(stderr) - some warnings/errors use this error_report() - goes to the monitor, if possible, otherwise stderr qemu_log_*() - goes to the qemu log, seems a little TCG-centric Thoughts? Stefan