----- Original Message ----- > From: "Eric Blake" <ebl...@redhat.com> > To: "Miroslav Rezanina" <mreza...@redhat.com> > Cc: qemu-devel@nongnu.org, kw...@redhat.com, pbonz...@redhat.com, > stefa...@redhat.com > Sent: Wednesday, February 13, 2013 2:39:59 PM > Subject: Re: [PATCH v11 3/4] qemu-img: Add compare subcommand > > On 02/13/2013 01:09 AM, Miroslav Rezanina wrote: > > This patch adds new qemu-img subcommand that compares content of > > two disk > > images. > > > > Signed-off-by: Miroslav Rezanina <mreza...@redhat.com> > > --- > > > +Compare exits with @code{0} in case the images are equal and with > > @code{1} > > +in case the images differ. Negative exit code means an error > > occurred during > > There's no such thing as a negative exit code.
Aaa, I forget to fix this. @stefanha: Can you please replace the work Negative with Others when applying. > > > +execution and standard error output should contain an error > > message. > > +Following table sumarize all exit codes of compare subcommand: > > s/sumarize/summarizes/ > @stefanha: Fix this typo too, thanks. > > + > > +@table @option > > + > > +@item 0 > > +Images are identical > > +@item 1 > > +Images differ > > +@item 2 > > +Error on opening an image > > +@item 3 > > +Error on checking a sector allocation > > +@item 4 > > +Error on reading data > > + > > +@end table > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > Thanks a lot, Eric. -- Miroslav Rezanina Software Engineer - Virtualization Team