On Fri, Feb 22, 2013 at 11:36 AM, Daniel P. Berrange <berra...@redhat.com> wrote: > On Fri, Feb 22, 2013 at 11:12:35AM +0100, Laurent Desnogues wrote: >> On Fri, Feb 22, 2013 at 12:04 AM, Anthony Liguori <aligu...@us.ibm.com> >> wrote: >> > >> > Since this is a pretty visible change for a lot of people, I thought I'd >> > send a top level note. The GTK UI is now committed and is the default >> > UI provided it's available. >> > >> > For anyone counting, it's been a little more than 7 years in the making: >> > >> > http://article.gmane.org/gmane.comp.emulators.qemu/9726 >> > >> > If you want to try it, make sure you have the gtk-2.0 development >> > packages installed and the VTE development packages. >> >> It looks like gtk_widget_get_window isn't available in all gtk 2 versions, >> at least it's not in the gtk2 2.10 on my CentOS 5.6 system. > > The docs say since 2.14 > > http://developer.gnome.org/gtk3/stable/GtkWidget.html#gtk-widget-get-window > > IIRC before that you could simply refernece widget->window directly. > So you could probably try adding something like this: > > #if ! GTK_CHECK_VERSION(2, 14, 0) > #define gtk_widget_get_window(w) (w)->window > #endif > > and see if that fixes your build.
That fixes the first error, but the others remain: ui/gtk.c: In function 'gd_resize': ui/gtk.c:254: warning: implicit declaration of function 'cairo_format_stride_for_width' ui/gtk.c:254: warning: nested extern declaration of 'cairo_format_stride_for_width' ui/gtk.c: In function 'gd_draw_event': ui/gtk.c:355: warning: implicit declaration of function 'gtk_widget_get_realized' ui/gtk.c:355: warning: nested extern declaration of 'gtk_widget_get_realized' ui/gtk.c: In function 'gd_vc_init': ui/gtk.c:864: error: 'VtePty' undeclared (first use in this function) ui/gtk.c:864: error: (Each undeclared identifier is reported only once ui/gtk.c:864: error: for each function it appears in.) ui/gtk.c:864: error: 'pty' undeclared (first use in this function) ui/gtk.c:885: error: 'GDK_KEY_2' undeclared (first use in this function) ui/gtk.c:897: warning: implicit declaration of function 'vte_pty_new_foreign' ui/gtk.c:897: warning: nested extern declaration of 'vte_pty_new_foreign' ui/gtk.c:899: warning: implicit declaration of function 'vte_terminal_set_pty_object' ui/gtk.c:899: warning: nested extern declaration of 'vte_terminal_set_pty_object' ui/gtk.c: In function 'gd_create_menus': ui/gtk.c:1009: error: 'GDK_KEY_f' undeclared (first use in this function) ui/gtk.c:1018: error: 'GDK_KEY_plus' undeclared (first use in this function) ui/gtk.c:1024: error: 'GDK_KEY_minus' undeclared (first use in this function) ui/gtk.c:1030: error: 'GDK_KEY_0' undeclared (first use in this function) ui/gtk.c:1045: error: 'GDK_KEY_g' undeclared (first use in this function) ui/gtk.c:1055: error: 'GDK_KEY_1' undeclared (first use in this function) ui/gtk.c: In function 'gtk_display_init': ui/gtk.c:1109: error: 'GDK_BLANK_CURSOR' undeclared (first use in this function) ui/gtk.c:1131: warning: implicit declaration of function 'gtk_widget_set_can_focus' ui/gtk.c:1131: warning: nested extern declaration of 'gtk_widget_set_can_focus' Thanks, Laurent
