li guang <lig.f...@cn.fujitsu.com> writes: > 在 2013-02-20三的 09:28 +0100，Markus Armbruster写道： >> liguang <lig.f...@cn.fujitsu.com> writes: >> >> > DEFAULT_MACHINE_OPTIONS is setting default boot_order, >> > while QEMUMachine already has default_machine_opts >> > to encapsulate some default options, so change it to >> > DEFAULT_MACHINE_BOOT_ORDER. >> >> Right now, DEFAULT_MACHINE_OPTIONS contains just a .boot_order >> initializer. But that's not necessarily so; it could contain anything. >> Avik, Anthony, you wrote or reviewed the patch that added it, what do >> you think? > > DEFAULT_MACHINE_OPTIONS seems same with default_machine_opts which is > already a member of QEMUMachine struct
I understand why you don't like the name DEFAULT_MACHINE_OPTIONS. However, I'm not sure DEFAULT_MACHINE_BOOT_ORDER is an improvement. DEFAULT_MACHINE_INITIALIZERS? Come to think of it, I dislike how commit e4ada29e sticks DEFAULT_MACHINE_OPTIONS into every machine declaration, and renaming it doesn't make me dislike it less. I'll try to clean this up, and report back
