Am 22.02.2013 20:01, schrieb Jens Freimann: > From: Christian Borntraeger <borntrae...@de.ibm.com> > > This patch fixes a crash when unplugging a virtio-ccw device. We no > longer need to do that in virtio-ccw since common code does now > proper handling. > > Signed-off-by: Christian Borntraeger <borntrae...@de.ibm.com> > Signed-off-by: Jens Freimann <jf...@linux.vnet.ibm.com> > --- > hw/s390x/virtio-ccw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c > index 231f81e..679afa6 100644 > --- a/hw/s390x/virtio-ccw.c > +++ b/hw/s390x/virtio-ccw.c > @@ -865,7 +865,6 @@ static int virtio_ccw_busdev_unplug(DeviceState *dev) > > css_generate_sch_crws(sch->cssid, sch->ssid, sch->schid, 1, 0); > > - object_unparent(OBJECT(dev)); > qdev_free(dev); > return 0; > }
qdev_free() does exactly object_unparent(), so in light of wanting to get away from qdev I would suggest to rather drop qdev_free() here. Paolo? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
