On Tue, Feb 26, 2013 at 09:55:48AM -0500, Jeff Cody wrote: > During a commit of 'all' using the HMP non-live commit, the operation > is aborted and returns error on the first error enountered. When > non-COW drives are in use (e.g. ejected floppy, cdrom, or drives without > a backing parent), that means a commit all will return an error of either > -ENOMEDIUM or -ENOTSUP. This is not desirable, so for the 'all' commit > case, only attempt the commit if both bs->drv and bs->backing_hd are > present. > > More succinctly: 'commit all' now means a commit on all COW drives. > > This means an individual commit to a specific non-COW drive will still > return the appropriate error (-ENOMEDIUM if eject / not present, -ENOTSUP > if no backing file). > > Reported-by: Jan Kiszka <jan.kis...@web.de> > Signed-off-by: Jeff Cody <jc...@redhat.com> > --- > block.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
