On Mon, Feb 25, 2013 at 11:05:31PM +0100, Andreas Färber wrote:
> > +
> > +static void vmxnet3_qdev_reset(DeviceState *dev)
> > +{
> > + VMXNET3State *s = DO_UPCAST(VMXNET3State, dev.qdev, dev);
>
> Cast macro
>
> Stefan, please keep an eye on such QOM issues during your review!
I'll try but I must admit I don't follow QOM developments closely. It's
similar to the monitor or migration: every time I touch it I have to
relearn the latest style.
I think we need to accept that QEMU is too big for a single person to
know all aspects. Thanks for reviewing this series!
Stefan
