On Thu, Feb 28, 2013 at 05:20:32PM +0800, Dong Xu Wang wrote: > Patch 1 add def_value_str and use it in qemu_opts_print. > > Patch 2 Create functions to pair with QemuOpts parser. > > Patch 3 Use QemuOpts parser in Block. > > Patch 4 Remove QEMUOptionParameter parser related code. > > > > Dong Xu Wang (4): > add def_value_str and use it in qemu_opts_print > Create four QemuOptsList related functions > Use QemuOpts support in block layer > remove QEMUOptionParameter related code > > block.c | 91 ++++----- > block/cow.c | 46 +++-- > block/gluster.c | 37 ++-- > block/iscsi.c | 8 +- > block/qcow.c | 61 +++--- > block/qcow2.c | 173 ++++++++-------- > block/qed.c | 86 ++++---- > block/qed.h | 2 +- > block/raw-posix.c | 59 +++--- > block/raw-win32.c | 31 +-- > block/raw.c | 30 +-- > block/rbd.c | 62 +++--- > block/sheepdog.c | 75 ++++--- > block/vdi.c | 70 ++++--- > block/vmdk.c | 90 +++++---- > block/vpc.c | 57 +++--- > block/vvfat.c | 11 +- > include/block/block.h | 4 +- > include/block/block_int.h | 6 +- > include/qemu/option.h | 46 ++--- > qemu-img.c | 61 +++--- > util/qemu-option.c | 490 > ++++++++++++++++++---------------------------- > 22 files changed, 723 insertions(+), 873 deletions(-) > > -- > 1.7.11.7 >
Looks fine at the high level. Markus had specific comments in the last version, please wait for his review before applying. Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
