On 03/27/2013 08:06 AM, Paolo Bonzini wrote:
Il 26/03/2013 17:28, Stefan Berger ha scritto:
QOM-ified the TPM support with much code borrowed from the rng implementation.
What's missing may be that the tpm/tpm_passthrough.c be moved into backends/ .
Signed-off-by: Stefan Berger <stef...@linux.vnet.ibm.com>
---
v1->v2:
- followed to git revision e769bdc26
---
backends/Makefile.objs | 2
backends/tpm.c | 154 ++++++++++++++++++++++++++++++++++++++++++++
include/qemu/tpm.h | 170
+++++++++++++++++++++++++++++++++++++++++++++++++
I think these should be tpm_backend.[ch] (with the include file in
include/tpm). Can you rename the existing files with that name first?
With the above file naming and directory placement I followed the pattern of
backends/rng.c
include/qemu/rng.h
So are you planning on having them renamed and moved as well?
My intention was to have tpm_passthrough moved into backends/.
There's a file tpm/tpm_backend.c -- you want me to rename this one even
though its located in a different directory?
Since I am not running a git repository any move/rename would be a
deletion of a file plus its addition.
Stefan
Paolo