Hi Stefan, This change is fine by me.
It's not clear to me, as the author/maintainer of the moxie port, what my responsibility/authority is. Do I simply reply to patches like this with... Looks good to me. Signed-off-by: Anthony Green <gr...@moxielogic.com> And then somebody commits it to the tree? Thanks! AG On Sun, Mar 24, 2013 at 4:04 AM, Stefan Weil <s...@weilnetz.de> wrote: > The type cast must use tcg_target_long instead of long. > This makes a difference for hosts where sizeof(long) != sizeof(void *). > > Cc: Anthony Green <gr...@moxielogic.com> > Cc: Blue Swirl <blauwir...@gmail.com> > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > target-moxie/translate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target-moxie/translate.c b/target-moxie/translate.c > index 34f166e..cc02bd3 100644 > --- a/target-moxie/translate.c > +++ b/target-moxie/translate.c > @@ -133,7 +133,7 @@ static inline void gen_goto_tb(CPUMoxieState *env, > DisasContext *ctx, > !ctx->singlestep_enabled) { > tcg_gen_goto_tb(n); > tcg_gen_movi_i32(cpu_pc, dest); > - tcg_gen_exit_tb((long) tb + n); > + tcg_gen_exit_tb((tcg_target_long)tb + n); > } else { > tcg_gen_movi_i32(cpu_pc, dest); > if (ctx->singlestep_enabled) { > -- > 1.7.10.4 >