Aurelien Jarno wrote: > Fabrice Bellard a écrit : >> IMHO it would be much simpler to do all the tests in the block format >> handlers. >> > > Do you mean move all the tests into block-{qcow,qcow2,vmdk}.c ?
I suggest reverting the patch and writing correct tests in block-{qcow,qcow2,vmdk}.c. BTW, bs->total_sectors is not a good indicator of the device size in case of removable devices for example. Fabrice.