Il 09/04/2013 13:42, Juan Quintela ha scritto: >> > @@ -556,11 +557,7 @@ static void qemu_fill_buffer(QEMUFile *f) >> > int len; >> > int pending; >> > >> > - if (!f->ops->get_buffer) >> > - return; > Why are we removing this test? this has nothing to do with the is_write > removal?
This test assumes that it makes sense to call qemu_get_byte on a write-opened QEMUFile. This is not true anymore after this patch. After eliminating is_write, the right thing to do is abort. Paolo > And yes, having a better way of knowing that the operations are there > looks like a good idea, but that is independent of this series.
