On 23 April 2013 22:46, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 23/04/2013 23:39, Peter Maydell ha scritto:
>> and our new function is >> MemoryRegionSection address_space_find_region(AddressSpace *as, >> MemoryRegion *mr); >> >> ? >> >> (we don't have to do the tidyup first, but the new function >> signature makes more sense viewed in the light of the others) > > I can look at it for 1.6, since I've already forward ported Avi's IOMMU > patches and added s/DMAContext/AddressSpace/ on top. > > What about 1.5 though? Ah, I was going to ask if this was a 1.5 series. If so, maybe just add and use that new function? Anyway, I don't want to bikeshed the function too much, as long as it takes an AddressSpace* to search and lets the caller distinguish "couldn't find the region" from valid actual addresses. thanks -- PMM