Eduardo Habkost <ehabk...@redhat.com> writes:

> On Thu, Apr 25, 2013 at 02:03:05PM -0500, Anthony Liguori wrote:
>> Laszlo Ersek <ler...@redhat.com> writes:
>> > --- /dev/null
>> > +++ b/hw/i386/acpi.h
>> > +
>> > +#include <stddef.h>
>> 
>> QEMU style would normally be to use qemu-common.h here but honestly I
>> prefer using system headers when it's possible.  Just FYI.
>
> I thought we were actively trying to stop including qemu-common.h from
> other header files, because it easily leads to unexpected (and hard to
> fix) circular header dependencies.

The problem is qemu-common including other headers, not other headers
including qemu-common...

But like I said in my original note, I don't like using qemu-common in
headers anyway.

Regards,

Anthony Liguori

>
> -- 
> Eduardo

Reply via email to