Am 24.05.2013 19:03, schrieb Paolo Bonzini: > With the next patch, the memory API will complain if the > TARGET_PHYS_ADDR_SPACE_BITS gets dangerously close to an > overflow. s390x can handle up to 64 bit of physical address > space from its page tables, but we never use that much. Just > decrease the value. > > Cc: Alexander Graf <ag...@suse.de> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
Didn't Avi introduce 128-bit arithmetic into QEMU to avoid 64-bit values overflowing? Why are you limiting Memory API to 62-bit now? Andreas > --- > target-s390x/cpu.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h > index 0ce82cf..6304c4d 100644 > --- a/target-s390x/cpu.h > +++ b/target-s390x/cpu.h > @@ -34,7 +34,10 @@ > #include "exec/cpu-defs.h" > #define TARGET_PAGE_BITS 12 > > -#define TARGET_PHYS_ADDR_SPACE_BITS 64 > +/* Actually 64-bits, limited by the memory API to 62 bits. We > + * never use that much. > + */ > +#define TARGET_PHYS_ADDR_SPACE_BITS 62 > #define TARGET_VIRT_ADDR_SPACE_BITS 64 > > #include "exec/cpu-all.h" > -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
