On Wed, 29 May 2013 14:29:51 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote:
> Il 29/05/2013 14:11, Andreas Färber ha scritto: > >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. > >> > >> This patch fixes the problem by removing the dummy CPU creation > >> altogether from xen_init_pv, relying on the fact that QEMU can now cope > >> with a machine without an emulated CPU. > >> > >> This fix should be backported to QEMU 1.5. > >> > >> Signed-off-by: Stefano Stabellini <stefano.stabell...@eu.citrix.com> > >> CC: imamm...@redhat.com > >> CC: qemu-sta...@nongnu.org > > > > Change looks okay, > > > > Reviewed-by: Andreas Färber <afaer...@suse.de> > > > > But for the future please avoid "this patch" in the commit message > > (because later on it's a "commit", not a patch) and also please put > > additional notices such as for backporting below the --- line. > > I read it as a warning to backporters that the patch, even though it may > apply, was not tested and may even be wrong in 1.4. it only needs to be backported to 1.5, 1.4 is not affected. > > Paolo >
