On 31 May 2013 10:04, Fabien Chouteau <chout...@adacore.com> wrote: > On 05/30/2013 07:26 PM, Peter Maydell wrote: >> * why this patch fixes it (probably with reference to the >> architecture manual and to what QEMU means when it sets >> "CPSR_I" on M profile [hint: look at how we handle PRIMASK]) > > I do not intend to do a full review of interrupt handling in the > M-profile.
My point is really that somebody needs to. M profile for me is low priority, but I know that a lot of our current implementation is dubious at best. So until somebody does step up who's willing to overhaul the M profile interrupt and exception handling code, I take a fairly hard line on reviewing band-aid patches which don't come with sufficiently convincing explanation of why they are correct, to at least avoid accidental regressions. thanks -- PMM
