On Thu, Oct 29, 2009 at 01:32:51AM +0900, TAKEDA, toshiya wrote: > This patch is to add private_features to i386. > It is like cpuid_ext*_features, but is used for any features not defined in > CPUID. > > And "a20mask" feature is defined in private_features. > It is for a20 adrdress mask of PC-98 family.
I'd suggest giving it a name like "pc98_a20mask" to make it clear that it's a PC-98 specific feature. TBH, I wonder whether this really belongs as a CPU feature, as it's not really something I would have thought should be exposed to the user... although perhaps the same could be said about CPUID bits generally... Presumably PC-98 provides the same A20 mask behaviour even when using a 486 or better (which IIUC have built-in A20 gate logic)? BTW, your patches need a 'signed-off-by' line, which is your statement that they follow the rules in the 'developer's certificate of origin': http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches Cheers, -- Stuart Brady