On Fri, May 31, 2013 at 06:46:21AM -0600, Eric Blake wrote: > On 05/31/2013 06:00 AM, Paolo Bonzini wrote: > > Two instances, both spotted by Coverity. In one, two blocks were > > swapped. In the other, the check is not needed anymore. > > > > Cc: qemu-sta...@nongnu.org > > Cc: qemu-triv...@nongnu.org > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > --- > > monitor.c | 2 +- > > savevm.c | 10 +++++----- > > 2 files changed, 6 insertions(+), 6 deletions(-) > > This version of the savevm.c fix is nicer than Stefan's attempt: > https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg04506.html > > Reviewed-by: Eric Blake <ebl...@redhat.com>
I'll drop mine. I didn't dare to swap the blocks just in case something dependend on doing the popen() and bailing out afterwards, but it's hard to imagine that. Stefan
