On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > This patch adds a transactional version of the drive-backup QMP command. > It allows atomic snapshots of multiple drives along with automatic > cleanup if there is a failure to start one of the backup jobs. > > Note that QMP events are emitted for block job completion/cancellation > and the block job will be listed by query-block-jobs. >
>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> blockdev.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
> qapi-schema.json | 40 +++++++++++++++++++++++++++++++++++++++-
> 2 files changed, 88 insertions(+), 1 deletion(-)
It would be nice if we could avoid copy-and-paste between the
transaction and the self-standing command, perhaps by teaching the qapi
code generator to recognize:
{ 'command': 'foo', 'data': 'DictType' }
as shorthand for
{ 'command': 'foo', 'data': { ...inlined contents of DictType... } }
But that is a cleanup that would apply to other existing qapi commands,
and is therefore better done as an independent series, and therefore
does not stop me from giving:
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
