On 4 June 2013 13:31, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 04/06/2013 14:24, Peter Maydell ha scritto: >> On 4 June 2013 13:13, Paolo Bonzini <pbonz...@redhat.com> wrote: >> This is much less flexible than just using sysbus_mmio_get_region(), >> because it only lets you pass the whole set of MMIOs from the >> other device through, not just the ones you want. > > How is this different from sysbus_pass_irq?
sysbus_pass_irq is also an annoyingly inflexible function. With MMIOs we have the advantage of being able to do better. >> Please just make reference counting work properly with passing >> MemoryRegion*s around. > > Do you have any idea that doesn't require touch 800 invocation of the > region creation functions? I think that would be a straightforward and easy to understand way to define the ownership rules so I would much rather we did that. I really don't like the way your current patch is doing something complicated in an attempt to avoid this. thanks -- PMM