I was surprised to find out that we still have old users of QERR_OPEN_FILE_FAILED that print errors like:
(qemu) dump-guest-memory -p /lkmads/foo Could not open '/lkmads/foo' (qemu) This series converts all those users to a new helper called error_setg_file_open(), which adds error reason to open failures: (qemu) dump-guest-memory -p /sfmdkjf/foo Could not open '/sfmdkjf/foo': No such file or directory (qemu) v2 - bdrv_reopen_prepare(): use generic error message - s/error/-ret for bdrv_open() errors Luiz Capitulino (9): error: add error_setg_file_open() helper rng-random: use error_setg_file_open() block: mirror_complete(): use error_setg_file_open() blockdev: use error_setg_file_open() cpus: use error_setg_file_open() dump: qmp_dump_guest_memory(): use error_setg_file_open() savevm: qmp_xen_save_devices_state(): use error_setg_file_open() block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED qerror: drop QERR_OPEN_FILE_FAILED macro backends/rng-random.c | 3 +-- block.c | 4 ++-- block/mirror.c | 2 +- blockdev.c | 11 +++++++---- cpus.c | 4 ++-- dump.c | 2 +- include/qapi/error.h | 5 +++++ include/qapi/qmp/qerror.h | 3 --- savevm.c | 2 +- util/error.c | 5 +++++ 10 files changed, 25 insertions(+), 16 deletions(-) -- 1.8.1.4
