05.06.2013 19:25, Michael Tokarev wrote: > In two places qemu uses openpty() which is very system-dependent, > and in both places the pty is switched to raw mode as well. > Make a wrapper function which does both steps, and move all the > system-dependent complexity into a separate file, together > with static/local implementations of openpty() and cfmakeraw() > from qemu-char.c. > > It is in a separate file, not part of oslib-posix.c, because > openpty() often resides in -lutil which is not linked to > every program qemu builds. > > This change removes #including of <pty.h>, <termios.h> > and other rather specific system headers out of qemu-common.h, > which isn't a place for such specific headers really.
So guys/gals what do you think of this? It builds on OpenBSD and FreeBSD as verified by Brad Smith and me, and it builds on Linux. And it is trivial enough for qemu-trivial (no actual code changes, just some refactoring and moving). Can we let it in? There's no one else who signed this off ;) > Signed-off-by: Michael Tokarev <m...@tls.msk.ru> Thanks, /mjt
