Am 11.06.2013 14:38, schrieb Michael Tokarev: > [Removing malc's email since it bounces] > 09.06.2013 16:22, Stefan Weil wrote: >> GCC_ATTR was only used in audio_int.h, so it is now unused and >> the definition can be removed from compiler.h. >> >> Signed-off-by: Stefan Weil <s...@weilnetz.de>
[snip] > This change (adding `inline') causes build failure with at least with gcc-4.7: > > audio/wavaudio.c: In function ‘dolog’: > audio/audio_int.h:246:100: error: function ‘dolog’ can never be inlined > because it uses variable argument lists > > $ gcc --version > gcc (Debian 4.7.2-5) 4.7.2 > > I think the addition of inline should be dropped here and in other > similar places (the rest is ok). > > I can do that myself if you want. > > Alternatively these functions can be turned into varargs #defines. > > Thanks, > > /mjt Thank you for reporting this compiler problem. I did not see it because I configured with -enable-debugwhich disables inline functions. I'll send a new patch which uses macros. Regards Stefan
