Am 17.06.2013 um 15:38 hat Pavel Hrdina geschrieben: > >>>>>It's just a warning, that you used a password for a block device that > >>>>>doesn't require it. The device is opened successfully and should be > >>>>>handled correctly (call the bdrv_dev_change_media_cb() ). > >>>> > >>>>Yep, IMO it's worth a comment that this isn't an "error" just a > >>>>"warning". > >>> > >>>Actually, you can't have such a warning in QMP. You either fail or you > >>>succeed. We should just do what the current code does. > >>> > >> > >>This is the same logic as the old one. The device is loaded but the > >>error is emitted. > > > >That's a bug if the operation succeeded. > > > > In that case, how do you think, that we should handle the situation > that user is trying to open device that isn't require the password, but > user will provide the password? > > I don't think that we should fail and abort that operation.
I think we should. The image and the options passed for it don't fit together, this is an error condition. Probably the user meant to pass a different image. Kevin
