Hi, >> If memory is set to 0xc2c2.., it leads to a spice-critical error when >> trying to start qxl.
> But maybe instead of doing it this way, we should just memset the > whole thing to 0, to avoid similar bugs in the future? Are there > any arches out there which have cpu_to_le32(0) != 0 ? On qemu + kvm guest memory (including pci device memory where this lives in) _is_ zero initialized. IIRC xen has a debug mode where it fills memory with non-zero values instead, for debugging / testing purposes, and this is where things blow up. So while the fix is clearly correct, the patch isn't as critical as it initially looks like. Reviewed-by: Gerd Hoffmann <kra...@redhat.com> cheers, Gerd
