For my own education, could you elaborate on the reason this is not a good change?
Thanks. JC ----- Mail original ----- > Il 25/06/2013 22:53, Peter Maydell ha scritto: > > On 25 June 2013 19:42, Paolo Bonzini <pbonz...@redhat.com> wrote: > >> Il 25/06/2013 20:21, Peter Maydell ha scritto: > >>> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev) > >>> > >>> sysbus_init_irq(dev, &s->irq); > >>> memory_region_init_io(&s->iomem, &imx_timerg_ops, > >>> - s, "imxg-timer", > >>> + s, TYPE_IMX_GPT, > >>> 0x00001000); > >>> sysbus_init_mmio(dev, &s->iomem); > >>> > >> > >> There was some agreement that this is not a good change. > > > > I agree (and more so regarding the use of the macro in the > > vmstate name), but nobody actually posted any comment to > > that effect against any of the versions of this patch that > > got sent out for review... > Yeah, the timing was bad... Can you post a revert, though? > Paolo
