Am 01.07.2013 19:16, schrieb Richard Henderson: > On 06/29/2013 01:01 PM, Andreas Färber wrote: >> Also use bool type while at it. >> >> Prepares for moving singlestep_enabled field to CPUState. >> >> Signed-off-by: Andreas Färber <afaer...@suse.de> >> --- >> target-xtensa/translate.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) > > All of 10-23/41, > > Reviewed-by: Richard Henderson <r...@twiddle.net>
I wonder, all targets seem to implement the same pattern of passing a hard-coded bool argument to their internal function. Is there any reason not to have translate-all.c call the function with that true/false directly? That would then call for using CPUState *cs argument and leaving FooCPU *cpu as local variable only where needed. In that case it would be a central change covering all targets in one patch. :) Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
