10.07.2013 08:45, Michael Tokarev wrote: [] > Besides, -- I just noticed -- we're discussing a V1 of this patch, > while I already sent a v3, -- it has a much more appropriate logic > for the Ctrl+C handling. The only issue I see with it is the make > check breakage which is easy to fix by s/==0/==1/.
I updated the git branch on my site -- http://git.corpit.ru/?p=qemu.git;a=shortlog;h=refs/heads/mjt-dt-nographic (two patches on the top). This now includes the `make check' fix by flipping the check (FW_CFG_NOGRAPHIC==1 vs ==0), more documentation rewording (suggested by Peter) and Reviewed-by tags. And yes, I dislike this mess too -- neither -nographic nor -display none should be tied with guest serial port. Better approach for the Ctrl+C handling has been proposed by pbonzini. Better suggestions for FW_CFG_NOGRAPHIC welcome. Maybe something like -serial-console (linux has console=ttyS0,tty1) which will be turned on by -nographic and which will be passed to firmware as FW_CFG_NOGRAPHIC, and which can be used in -serial none case to check for sanity. But actually, -display none isn't that bad of a choice here (and maybe we may also enforce non-none serial in case of -display none). Thanks, /mjt
