Am 19.07.2013 00:40, schrieb Alexander Graf: > On 18.07.2013, at 21:49, Stefan Weil wrote: > >> Am 16.07.2013 07:54, schrieb Stefan Weil: >>> Am 12.07.2013 18:48, schrieb Stefan Weil: >>>> Fix a number of warnings for 32 bit builds (tested on MingW and Linux): >>>> >>>> CC hw/ide/macio.o >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb': >>>> qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type >>>> 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c: In function 'pmac_ide_transfer_cb': >>>> qemu/hw/ide/macio.c:215:5: error: format '%ld' expects argument of type >>>> 'long int', but argument 5 has type 'int64_t' [-Werror=format] >>>> qemu/hw/ide/macio.c:222:9: error: format '%lx' expects argument of type >>>> 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> qemu/hw/ide/macio.c:264:9: error: format '%lx' expects argument of type >>>> 'long unsigned int', but argument 3 has type 'hwaddr' [-Werror=format] >>>> cc1: all warnings being treated as errors >>>> make: *** [hw/ide/macio.o] Error 1 >>>> >>>> Signed-off-by: Stefan Weil <s...@weilnetz.de> >>>> --- >>>> >>>> >>>> >>>> Hi Anthony, >>>> >>>> the patch fixes a build regression which was introduced today. >>>> Could you please apply it without waiting for the next pull requests? >>>> >>>> Thanks, >>>> Stefan
[...] > Acked-by: Alexander Graf <ag...@suse.de> I assume this can go through > the trivial tree? Or directly get applied by Anthony? Alex I still think that build regressions should be fixed by a direct maintainer commit instead of waiting for a pull request, but obviously this does not happen here (why?). So hopefully the fix will be committed via qemu-trivial at least. See http://patchwork.ozlabs.org/patch/258774/ for the full patch. Stefan
