Am 22.07.2013 23:03, schrieb Seiji Aguchi: > Convert stderr messages calling error_get_pretty() > to error_report(). > > Timestamp is prepended by -msg timstamp option with it. > > This is suggested by Luiz Capitulino. > > http://marc.info/?l=qemu-devel&m=137331442628866&w=2 > > Signed-off-by: Seiji Aguchi <seiji.agu...@hds.com> > --- > arch_init.c | 4 ++-- > hw/char/serial.c | 5 +++-- > hw/i386/pc.c | 6 +++--- > qemu-char.c | 2 +- > target-i386/cpu.c | 2 +- > target-ppc/translate_init.c | 3 ++- > vl.c | 9 +++++---- > 7 files changed, 17 insertions(+), 14 deletions(-)
How is this related to error_get_pretty()? And does error_report() expect a trailing \n or not? I would assume no, but spotted some in this patch. If you feel strongly about having error_report() consistently, please let me know if there are any in my qom-next queue that need fixing. https://github.com/afaerber/qemu-cpu/commits/qom-next Thanks, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
