23.07.2013 21:00, Petar Jovanovic wrote: > From: Petar Jovanovic <petar.jovano...@imgtec.com> > > sys_mremap missed 5th argument (new_address), which caused examples that > remap to a specific address to fail. > sys_splice missed 5th and 6th argument which caused different examples to > fail. > This change has an effect on MIPS target only.
While splice is obvious and appears to be correct, with mremap I'm not this sure. The last, 5th argument of mremap(), which is `void *new_address', is optional and may be either present or not. So, without understanding how the underlying tables/code works, I'm not really sure if the resulting change will work or not. On the other hand, sys_open is also declared as having 3 arguments while the 3rd one (mode) is also optional, so the patch appears to be correct there as well, so I was almost ready to apply it, until your last comment which states that the change has only effect on MIPS. Which is quite puzzling to me who, again, does not really know how the code works. So either the patch isn't trivial enough, or maybe you can provide some more verbose explanation... ;) Thanks, /mjt