On 07/26/2013 01:16 PM, Kevin Wolf wrote:
> Instead of the rather verbose syntax that distinguishes base and
> subclass fields...
>
> { "type": "file",
> "read-only": true,
> "data": {
> "filename": "test"
> } }
>
> ...we can now have both in the same namespace, allowing a more direct
> mapping of the command line, and moving fields between the common base
> and subclasses without breaking the API:
>
> { "driver": "file",
> "read-only": true,
> "filename": "test" }
>
> Signed-off-by: Kevin Wolf <kw...@redhat.com>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
> ---
> docs/qapi-code-gen.txt | 22 ++++++++++++
> scripts/qapi-types.py | 11 ++++--
> scripts/qapi-visit.py | 90
> +++++++++++++++++++++++++++++++++++++-------------
> 3 files changed, 98 insertions(+), 25 deletions(-)
>
> v2:
> - make check failed because some of the nested struct code didn't correctly
> put separators between the field names, ending up with foo.barbaz instead
> of foo.bar.baz for fields, and foo_barbar instead of foo_bar_baz for
> functions. Fixed that.Serves me right for doing just a visual code review instead of 'git am && make check'; but now you know why I only gave Reviewed-by instead of the stronger Acked-by. At any rate, this version looks better; Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
