Il 13/08/2013 00:07, Alex Williamson ha scritto:
>> > +    if (pci_iommu_as(pdev) != &address_space_memory) {
>> > +        error_report("vfio: DMA address space must be system memory");
>> > +        return -ENXIO;
> -EFAULT?  It's a bad address of sorts.
> 

Accessing it would SIGSEGV, so it is not really EFAULT.  I would just
use EINVAL, the numeric error code will go away as soon as initfn is
changed to use "Error *" (which is needed to propagate sensible error
messages to the QMP client).

Paolo

Reply via email to