Am 28.08.2013 um 10:08 hat Max Reitz geschrieben: > Add tests for qemu-img amend on qcow2 image files. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > This test is numbered 061 for not interfering with my "metadata overlap > checks" series (although I will have to adapt my code to those new checks > anyway when/if they are included in master). > --- > tests/qemu-iotests/061 | 121 +++++++++++++++++++ > tests/qemu-iotests/061.out | 289 > +++++++++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/group | 1 + > 3 files changed, 411 insertions(+) > create mode 100755 tests/qemu-iotests/061 > create mode 100644 tests/qemu-iotests/061.out
The existing cases look good. I would add some _check_test_img calls after each amendment, and perhaps include a few cases with non-standard cluster_size etc. during image creation (which would show that your TODO isn't addressed yet). Kevin
