Am 29.08.2013 20:19, schrieb Alex Bligh: > sleep() apparently doesn't exist under mingw. Use g_usleep for > portability. > > Signed-off-by: Alex Bligh <[email protected]> > --- > tests/test-aio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/test-aio.c b/tests/test-aio.c > index 4215701..110fa4a 100644 > --- a/tests/test-aio.c > +++ b/tests/test-aio.c > @@ -400,7 +400,7 @@ static void test_timer_schedule(void) > g_assert(!aio_poll(ctx, false)); > g_assert_cmpint(data.n, ==, 0); > > - sleep(1); > + g_usleep(1*G_USEC_PER_SEC); > g_assert_cmpint(data.n, ==, 0); > > g_assert(aio_poll(ctx, false)); > @@ -736,7 +736,7 @@ static void test_source_timer_schedule(void) > > g_assert_cmpint(data.n, ==, 0); > > - sleep(1); > + g_usleep(1*G_USEC_PER_SEC); > g_assert_cmpint(data.n, ==, 0); > > g_assert(g_main_context_iteration(NULL, false)); > @@ -746,7 +746,7 @@ static void test_source_timer_schedule(void) > do { > g_assert(g_main_context_iteration(NULL, true)); > } while (qemu_clock_get_ns(data.clock_type) <= expiry); > - sleep(1); > + g_usleep(1*G_USEC_PER_SEC); > g_main_context_iteration(NULL, false); > > g_assert_cmpint(data.n, ==, 2);
Although checkpatch.pl does not complain, I'd prefer a blank before and after operators like "*". Here a simple g_usleep(G_USEC_PER_SEC) would be even better. Otherwise this patch is fine. Regards, Stefan
