On Thu, 2013-09-05 at 16:37 -0600, Eric Blake wrote: > On 09/05/2013 04:29 PM, Alex Williamson wrote: > > Remove carriage returns and tweak formatting for error_reports. > > > > Signed-off-by: Alex Williamson <alex.william...@redhat.com> > > --- > > hw/misc/vfio.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c > > index 730dec5..a73e7f5 100644 > > --- a/hw/misc/vfio.c > > +++ b/hw/misc/vfio.c > > @@ -3055,13 +3055,15 @@ static int vfio_get_device(VFIOGroup *group, const > > char *name, VFIODevice *vdev) > > ret = ioctl(vdev->fd, VFIO_DEVICE_GET_IRQ_INFO, &irq_info); > > if (ret) { > > /* This can fail for an old kernel or legacy PCI dev */ > > - DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure ret=%d\n", ret); > > + DPRINTF("VFIO_DEVICE_GET_IRQ_INFO failure: %m\n"); > > %m is a glibc extension, and does not exist on all platforms. You > should probably not make this change.
It's not the only instance of %m in this file and, IIRC, was previously suggested by Anthony. Are we banning %m now? Thanks, Alex