On Fri, Sep 20, 2013 at 01:12:37PM -0400, Jeff Cody wrote:
> Changes in v3:
> 
> Patch 1: MANIFEST file dropped.  Instead of bunzip2, use bzcat.  Check error
>          return of bzcat.  Don't attempt to remove $SAMPLE_IMG_FILE if the
>          variable is blank.
> 
> Patch 2: MANIFEST file dropped.
> 
> Patch 3: New patch.  This adds some cleanup in the format of quotations around
>          filenames and paths in the io tests.
> 
> This provides:
> 
> Patch 1/3:  A basic framework for using sample image files.  This is intended
>             to be sample images created with the image format native tool; 
> e.g.
>             a VHDX image created with Hyper-V.
> 
> Patch 2/3:  VHDX read test on a sample image created with Hyper-V.
> 
> Patch 3/3:  Quote around usage of $TEST_IMG and $TEST_DIR, so that pathnames
>             and filenames with spaces can safely be used.
> 
> Jeff Cody (3):
>   block: qemu-iotests - add basic ability to use binary sample images
>   block: qemu-iotests for vhdx, read sample dynamic image
>   block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage
> 
>  tests/qemu-iotests/001                             |   6 +-
>  tests/qemu-iotests/002                             |  36 ++++++------
>  tests/qemu-iotests/003                             |  10 ++--
>  tests/qemu-iotests/004                             |  24 ++++----
>  tests/qemu-iotests/005                             |   4 +-
>  tests/qemu-iotests/007                             |   2 +-
>  tests/qemu-iotests/008                             |   6 +-
>  tests/qemu-iotests/009                             |   2 +-
>  tests/qemu-iotests/010                             |   2 +-
>  tests/qemu-iotests/011                             |   2 +-
>  tests/qemu-iotests/012                             |   4 +-
>  tests/qemu-iotests/013                             |   4 +-
>  tests/qemu-iotests/014                             |   2 +-
>  tests/qemu-iotests/015                             |  16 +++---
>  tests/qemu-iotests/016                             |  12 ++--
>  tests/qemu-iotests/018                             |   6 +-
>  tests/qemu-iotests/019                             |  12 ++--
>  tests/qemu-iotests/020                             |  12 ++--
>  tests/qemu-iotests/021                             |   2 +-
>  tests/qemu-iotests/023                             |   4 +-
>  tests/qemu-iotests/024                             |  12 ++--
>  tests/qemu-iotests/025                             |   4 +-
>  tests/qemu-iotests/026                             |  20 +++----
>  tests/qemu-iotests/027                             |  10 ++--
>  tests/qemu-iotests/028                             |   6 +-
>  tests/qemu-iotests/029                             |  12 ++--
>  tests/qemu-iotests/031                             |  12 ++--
>  tests/qemu-iotests/032                             |   4 +-
>  tests/qemu-iotests/033                             |  18 +++---
>  tests/qemu-iotests/034                             |  64 
> ++++++++++-----------
>  tests/qemu-iotests/035                             |   2 +-
>  tests/qemu-iotests/036                             |   6 +-
>  tests/qemu-iotests/037                             |  62 ++++++++++----------
>  tests/qemu-iotests/038                             |  10 ++--
>  tests/qemu-iotests/039                             |  28 ++++-----
>  tests/qemu-iotests/042                             |  10 ++--
>  tests/qemu-iotests/043                             |  32 +++++------
>  tests/qemu-iotests/046                             |  10 ++--
>  tests/qemu-iotests/047                             |   2 +-
>  tests/qemu-iotests/048                             |   8 +--
>  tests/qemu-iotests/049                             |  36 ++++++------
>  tests/qemu-iotests/050                             |  20 +++----
>  tests/qemu-iotests/051                             |  50 ++++++++--------
>  tests/qemu-iotests/052                             |   6 +-
>  tests/qemu-iotests/053                             |  10 ++--
>  tests/qemu-iotests/054                             |   2 +-
>  tests/qemu-iotests/059                             |   6 +-
>  tests/qemu-iotests/063                             |  28 ++++-----
>  tests/qemu-iotests/064                             |  62 ++++++++++++++++++++
>  tests/qemu-iotests/064.out                         |  14 +++++
>  tests/qemu-iotests/common                          |   6 ++
>  tests/qemu-iotests/common.config                   |  11 ++++
>  tests/qemu-iotests/common.rc                       |  32 ++++++++---
>  tests/qemu-iotests/group                           |   1 +
>  tests/qemu-iotests/sample_images/README            |   8 +++
>  .../sample_images/iotest-dynamic-1G.vhdx.bz2       | Bin 0 -> 874 bytes
>  56 files changed, 455 insertions(+), 337 deletions(-)
>  create mode 100755 tests/qemu-iotests/064
>  create mode 100644 tests/qemu-iotests/064.out
>  create mode 100644 tests/qemu-iotests/sample_images/README
>  create mode 100644 
> tests/qemu-iotests/sample_images/iotest-dynamic-1G.vhdx.bz2
> 
> -- 
> 1.8.3.1
> 
> 

Looks good but requires a one-line change.  The last patch is incorrect:

-    rm -f $TEST_IMG.[123].base
+    rm -f "$TEST_IMG.[123].base"

Jeff has suggested this instead:

-    rm -f $TEST_IMG.[123].base
+    rm -f "$TEST_IMG".[123].base

Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>

Reply via email to