On 10/08/2013 03:29 AM, Fam Zheng wrote: > Switch the string to enum type BlockJobType in BlockJobDriver. > > Signed-off-by: Fam Zheng <f...@redhat.com> > ---
> +++ b/include/block/blockjob.h
> @@ -37,7 +37,7 @@ typedef struct BlockJobDriver {
> size_t instance_size;
>
> /** String describing the operation, part of query-block-jobs QMP API */
> - const char *job_type;
> + BlockJobType job_type;
Comment looks awkward now that it is not a string in memory; but it is
still a string on the wire, so I can live with it as-is.
Series: Reviewed-by: Eric Blake <ebl...@redhat.com>
Thanks for doing this!
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
