On 26 September 2013 22:03, Christoffer Dall
<christoffer.d...@linaro.org> wrote:
> @@ -606,10 +607,13 @@ static void gic_cpu_write(GICState *s, int cpu, int
> offset, uint32_t value)
> s->priority_mask[cpu] = (value & 0xff);
> break;
> case 0x08: /* Binary Point */
> - /* ??? Not implemented. */
> + s->bpr[cpu] = (value & 0x7);
> break;
> case 0x10: /* End Of Interrupt */
> return gic_complete_irq(s, cpu, value & 0x3ff);
> + case 0x1c: /* Aliased Binary Point */
> + s->abpr[cpu] = (value & 0x7);
> + break;
The ABPR should RAZ/WI for GICs prior to v2, so this needs
to be guarded with "if (s->revision >= 2) { ...".
Otherwise looks good.
-- PMM
