On 16 October 2013 15:19, Tom Musta <tommu...@gmail.com> wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer.
This contribution needs an explicit statement that it's licensed under the softfloat-2a license (or at worst some other GPL-2 compatible license), because we're in the middle of doing a relicensing on this file. If you say something like "This contribution can be licensed under either the softfloat-2a or -2b license." that would be sufficient. > Note that the patch does not pass scripts/checkpatch.pl because it > maintains the coding style of fpu/softfloat.c. We've also accepted contributions which move the file gradually towards QEMU coding style, so either way is acceptable. thanks -- PMM
