On Thu, Oct 17, 2013 at 09:58:47AM +0200, Stefan Hajnoczi wrote: > On Thu, Oct 17, 2013 at 03:02:48PM +0800, Amos Kong wrote: > > I tried to change macaddr in guest, addr in guest is updated, and guest > > network is fine. But the nic information in monitor isn't update. This > > problem both exists in e1000 and rtl8139. > > > > 1) change macaddr in guest by ifconfig > > guest)# ifconfig eth0 hw ether 12:12:12:34:35:36 > > guest)# ifconfig eth0 > > > > 2) check network information in monitor > > (qemu) info network > > > > Amos Kong (2): > > net/e1000: update network information when macaddr is changed in guest > > net/rtl8139: update network information when macaddr is changed in > > guest > > > > hw/net/e1000.c | 8 ++++++++ > > hw/net/rtl8139.c | 6 +++++- > > 2 files changed, 13 insertions(+), 1 deletion(-) > > Thanks, applied to my net tree: > https://github.com/stefanha/qemu/commits/net > > Stefan
Please revert, this is buggy: info is changed on guest mac write but is not reverted on reset. Let's fix it properly, no need to introduce new regressions when fixing old bugs :) -- MST