On Thu, Oct 17, 2013 at 09:23:26PM +0200, Stefan Weil wrote: > Report from valgrind: > > ==19521== Source and destination overlap in memcpy(0x31d38938, 0x31d38938, 64) > ==19521== at 0x4A0A343: memcpy@@GLIBC_2.14 (in > /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) > ==19521== by 0x42774E: virtio_blk_device_init (virtio-blk.c:686) > ==19521== by 0x46EE9E: virtio_device_init (virtio.c:1158) > ==19521== by 0x25405E: device_realize (qdev.c:178) > ==19521== by 0x2559B5: device_set_realized (qdev.c:699) > ==19521== by 0x3A819B: property_set_bool (object.c:1315) > ==19521== by 0x3A6CE0: object_property_set (object.c:803) > > Valgrind is right: blk == &s->blks, so it is a memcpy of 64 byte with > source == destination which can be removed. > > Reported-by: Dave Airlie <airl...@gmail.com> > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > hw/block/virtio-blk.c | 1 - > 1 file changed, 1 deletion(-)
Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan