On 11/06/2013 11:13 AM, Eric Blake wrote:
On 11/06/2013 07:39 AM, Corey Bryant wrote:
[your git settings are odd; your messages came across as individual
threads rather than in-reply to the cover letter]
I wonder if that's because I sent each patch separately with git
send-email? Sometimes it hangs when I send more than 1.
This patch provides HMP 'info tpm', QMP 'query-tpm' and QMP
'query-tpm-types' support for the libtpms TPM backend.
Signed-off-by: Corey Bryant <cor...@linux.vnet.ibm.com>
---
hmp.c | 5 +++++
include/sysemu/tpm_backend.h | 1 +
qapi-schema.json | 18 ++++++++++++++++--
tpm.c | 7 +++++++
4 files changed, 29 insertions(+), 2 deletions(-)
+++ b/qapi-schema.json
@@ -3673,10 +3673,11 @@
# An enumeration of TPM types
#
# @passthrough: TPM passthrough type
+# @libtpms: TPM libtpms type
Worth adding '(since 1.8)' to mark when this enum value was added.
# @TpmTypeOptions:
#
# A union referencing different TPM backend types' configuration options
#
# @passthrough: The configuration options for the TPM passthrough type
+# @libtpms: The configuration options for the TPM libtpms type
here as well.
#
# Since: 1.5
##
{ 'union': 'TpmTypeOptions',
- 'data': { 'passthrough' : 'TPMPassthroughOptions' } }
+ 'data': { 'passthrough' : 'TPMPassthroughOptions',
+ 'libtpms' : 'TPMLibtpmsOptions' } }
Otherwise it looks okay to me.
Thanks for the comments. I'll add them to the next version. Can I add
your Reviewed-by to this patch?
--
Regards,
Corey Bryant
