On 11/08/13 16:42, Andreas Färber wrote: > Am 07.11.2013 21:27, schrieb Jordan Justen: >> On Sun, Nov 3, 2013 at 12:48 PM, Marcel Apfelbaum <marce...@redhat.com> >> wrote: >>> The commit: >>> >>> Commit: a53ae8e934cd54686875b5bcfc2f434244ee55d6 >>> Author: Marcel Apfelbaum <marce...@redhat.com> >>> Date: Mon Sep 16 11:21:16 2013 +0300 >>> >>> hw/pci: partially handle pci master abort >>> >>> introduced a regression on make check: >> >> Laszlo pointed out that my OVMF flash support series was not working >> with QEMU master. It was working with QEMU 1.6.0. I then bisected the >> issue to this commit. It seems this commit regresses -pflash support >> for both KVM and non-KVM modes. >> >> Can you reproduce the issue this with command? >> x86_64-softmmu/qemu-system-x86_64 -pflash pc-bios/bios.bin >> (with or without adding -enable-kvm) > > Jordan or Laszlo, > > Can either of you please add a small test case to i440fx-test using > -pflash and doing a read in the PCI hole (or wherever exactly) so that > we can avoid regressing yet again? :)
For -pflash we need a small test file. I'm thinking about creating a 512 byte (1 sector) big file, and modifying the qemu command line in "tests/i440fx-test.c". I'm not very familiar with external files in tests though. Can I model it on "qdict-test-data.txt"? "qdict-test-data.txt" is located in the root source directory. When configure runs outside the root source directory (= separate build dir), it symlinks it. And, the "check-qdict.c" test program opens it (with fopen()) simply by basename (no path prefix). Can I follow that? Thanks Laszlo
