On 18 November 2013 13:12, Michael Matz <m...@suse.de> wrote: > Hi, > > On Mon, 18 Nov 2013, Claudio Fontana wrote: > >> >> + case 3: >> >> + tcg_gen_rotr_i64(r, cpu_reg(reg), tcg_shift); >> >> + break; >> > >> > Incorrect rotate for 32bit? > > 32bit rotates and shifts were fixed in a patch later than the 60er series > Alex posted. See attached. (Generally there are many fixes to emulated > instructions in that branch)
I think we're going to need to look through and fold in those fixes, otherwise we'll end up reduplicating that work in the course of code review :-( -- PMM
