On Mon, Nov 18, 2013 at 04:40:39PM +0100, Kevin Wolf wrote: > Am 18.11.2013 um 16:32 hat Stefan Hajnoczi geschrieben: > > On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: > > > The default cache mode for drive options is changed to writethrough, and > > > overridable with "./check -c <mode>". > > > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > > --- > > > tests/qemu-iotests/common | 13 ++++++++++++- > > > tests/qemu-iotests/iotests.py | 3 ++- > > > 2 files changed, 14 insertions(+), 2 deletions(-) > > > > BTW, I looked back at Kevin's reply to your earlier patch and saw he > > suggested making the default "writethrough". > > > > Kevin: Any reason not to use "writeback" by default? > > I'm not opposed to changing the default in a second step. It's just that > writethrough is the default today and tests not respecting this are > buggy. So the incremental fix is to make them obey the global setting, > and then that setting can be tweaked in a second step.
Makes sense. Stefan
