Il 29/11/2013 16:30, Laszlo Ersek ha scritto: >> > Zero-fill immediately followed by read. Suggest to drop memset(). > Same as above. memread() is unable to report errors. Some C library > functions also require you to set errno to zero first, then call the > function, then check errno, because some of the return values are > overlapped by success and failure returns. For memread() there's no > distinction in return value at all. >
Errors in memread() will cause an assertion failure, but I think it's okay to use g_malloc0. That said, I agree that the common coding conventions (as well as the English grammar) makes "char unsigned" look a bit weird. Regarding usage of fixtures, I think it's within your artistic license (quoting) and it's good to have an example to cut-and-paste from Paolo.