On 2013年12月03日 17:28, Kevin Wolf wrote: > Am 03.12.2013 um 09:21 hat Fam Zheng geschrieben: >> On 2013年12月03日 14:05, Wenchao Xia wrote: >> >>> >>> Why forbid mode = writeback? >>> >> >> These test cases used to run with only possibly "writethrough", or "none". >> And they don't work with writeback, at least in my case. So I didn't add >> other modes here. > > I suspect that the tests allowing writethrough might also work with > directsync. Did you give that one a try? >
I guess so. Except for my /tmp is tmpfs and complains about O_DIRECT. It works for me with "TMPDIR=/var/tmp". > 026 has different output for wt and wb modes, this is why writeback > fails. It should probably check against 026.out.nocache (which would > have to be renamed as 026.out.wb) instead of 026.out. That's something > for a separate series, though. > Yes, good idea. I'll do this and the directsync including in the next series. Fam